linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: adf4377: add adf4378 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240727133024.4cf167ef@jic23-huawei>
Date: Sat, 27 Jul 2024 13:30:24 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Dragos Bogdan <dragos.bogdan@...log.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adf4377: add adf4378 support

On Mon, 22 Jul 2024 17:26:37 +0100
Conor Dooley <conor@...nel.org> wrote:

> On Mon, Jul 22, 2024 at 04:45:05PM +0300, Antoniu Miclaus wrote:
> > Add porperty conditions for the adf4378.

property

> > Add product link for the adf4378.  
> 
> I can see this from the diff. You need to explain /why/ this gpio is not
> valid for use on this device.
> 
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---
> > changes in v2:
> >  - use property conditions for clk2 gpio
> > Note: the compatible is already available from the firs iteration of the driver
> > where these particularities weren't available for adf4378
> >  .../devicetree/bindings/iio/frequency/adi,adf4377.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> > index aa6a3193b4e0..5f950ee9aec7 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> > @@ -17,6 +17,7 @@ description: |
> >     applications.
> >  
> >     https://www.analog.com/en/products/adf4377.html
> > +   https://www.analog.com/en/products/adf4378.html
> >  
> >  properties:
> >    compatible:
> > @@ -73,6 +74,15 @@ required:
> >  
> >  allOf:
> >    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - adi,adf4378
> > +    then:
> > +      properties:
> > +        clk2-enable-gpios: false
> >  
> >  unevaluatedProperties: false
> >  
> > -- 
> > 2.45.2
> >