linux-kernel - Re: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqTtu1Qdz9e9/Fnm@csail.mit.edu>
Date: Sat, 27 Jul 2024 12:53:15 +0000
From: "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>
To: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
Cc: Dexuan Cui <decui@...rosoft.com>,
	Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Saurabh Singh Sengar <ssengar@...rosoft.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks

On Fri, Jul 26, 2024 at 04:26:19AM -0700, Saurabh Singh Sengar wrote:
> On Fri, Jul 26, 2024 at 06:34:53AM +0000, Srivatsa S. Bhat wrote:
> > On Fri, Jul 26, 2024 at 12:01:33AM +0000, Dexuan Cui wrote:
> > > > From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
> > > > Sent: Thursday, July 25, 2024 8:35 AM
> > > > Subject: Re: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks
> > > 
> > > Without the patch, I think the current CPU uses IPIs to let the other
> > > CPUs, one by one,  run the function calls, and synchronously waits
> > > for the function calls to finish.
> > > 
> > > IMO the patch is not "Deferring per cpu tasks". "Defer" means "let it
> > > happen later". Here it schedules work items to different CPUs, and
> > > the work items immediately start to run on these CPUs.
> > > 
> > > I would suggest a more accurate subject:
> > > Drivers: hv: vmbus: Run hv_synic_init() concurrently
> > > 
> > 
> > It would be great to call out the "why" as well in the title,
> > something like:
> > 
> > Drivers: hv: vmbus: Speed-up booting by running hv_synic_init() concurrently
> 
> Thanks, I can also rephrase it like below if sounds fine to you:
> 
> Drivers: hv: vmbus: Optimize boot time by concurrent execution of hv_synic_init()
> 

Sure, that sounds good too.

Regards,
Srivatsa
Microsoft Linux Systems Group