linux-kernel - Re: [syzbot] [ntfs3?] possible deadlock in ntfs_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240727224040.2248-1-hdanton@sina.com>
Date: Sun, 28 Jul 2024 06:40:40 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+c1751b6739d83d70bb75@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [ntfs3?] possible deadlock in ntfs_file_mmap

On Sat, 27 Jul 2024 06:44:20 -0700
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    2f8c4f506285 Merge tag 'auxdisplay-for-v6.11-tag1' of git:..
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12e875a1980000

#syz test upstream  2f8c4f506285

--- x/fs/ntfs3/file.c
+++ y/fs/ntfs3/file.c
@@ -365,7 +365,10 @@ static int ntfs_file_mmap(struct file *f
 		}
 
 		if (ni->i_valid < to) {
-			inode_lock(inode);
+			if (!inode_trylock(inode)) {
+				err = -EDEADLK;
+				goto out;
+			}
 			err = ntfs_extend_initialized_size(file, ni,
 							   ni->i_valid, to);
 			inode_unlock(inode);
--