[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <99e5b9275d6c7750e916e83b9191e965@manjaro.org>
Date: Sun, 28 Jul 2024 11:22:48 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Andy Yan <andyshrk@....com>
Cc: heiko@...ech.de, krzk+dt@...nel.org, robh@...nel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5
GenBook
Hello Andy,
On 2024-07-28 10:20, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect
> with CM5.
>
> Signed-off-by: Andy Yan <andyshrk@....com>
>
> ---
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..a9bfb87e69f5 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,genbook
This should also follow the "dependency graph" naming approach, so it
should be named "coolpi,pi-cm5-genbook" instead. It would also make
the naming scheme future-proof for some other SoM that could possibly
be made available for the GenBook in the future, for which the new
identifier would be "coolpi,pi-XYZ-genbook".
Though, the "pi-" part in "coolpi,pi-cm5-genbook" seems redundant to
me, but it's already present in all related Cool Pi identifiers, e.g.
"coolpi,pi-cm5-evb", so including the leading "pi-" here as well is
obviously required for consistency.
Oh, and I somehow managed to miss this in my earlier repose, which
would have saved you from sending another version of this series.
I'm sorry for that.
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> +
> - description: Cool Pi 4 Model B
> items:
> - const: coolpi,pi-4b
Powered by blists - more mailing lists