linux-kernel - Re: [PATCH v8 RESEND 1/3] dt-bindings: dmaengine: Add dma multiplexer for CV18XX/SG200X series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240729150201.GA334758-robh@kernel.org>
Date: Mon, 29 Jul 2024 10:02:01 -0500
From: Rob Herring <robh@...nel.org>
To: Inochi Amaoto <inochiama@...look.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Albert Ou <aou@...s.berkeley.edu>, devicetree@...r.kernel.org,
	Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	dmaengine@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	Liu Gui <kenneth.liu@...hgo.com>, linux-riscv@...ts.infradead.org,
	Chen Wang <unicorn_wang@...look.com>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v8 RESEND 1/3] dt-bindings: dmaengine: Add dma
 multiplexer for CV18XX/SG200X series SoC

On Mon, Jul 29, 2024 at 08:28:09PM +0800, Inochi Amaoto wrote:
> On Mon, Jul 29, 2024 at 11:30:20AM GMT, Krzysztof Kozlowski wrote:
> > On 29/07/2024 09:00, Inochi Amaoto wrote:
> > >> yamllint warnings/errors:
> > >>
> > >> dtschema/dtc warnings/errors:
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/sophgo,cv1800-dmamux.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/sophgo,cv1800-dmamux.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/dma-router.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/dma-router.yaml#
> > >>
> > > 
> > > Hi Rob,
> > > 
> > > Could you share some suggestions? I can not reproduce this error with
> > > latest dtschema. I think this is more like a misreporting.
> > 
> > You would need dtschema from the master branch, so newer than 2024.05.
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Is it a must for the type array to have more than 1 element?
> I have tested the value "<&dmac 0>" and "<&dmac>, <&dmac>".
> Both pass the check (These value are just for test, not the
> real hardware).
> 
> Setting dma-masters to type "phandle" also has no change. 
> It do not accept the value "<&dmac>", Is there any suggestion
> for this? Thanks in advance.

The issue is 'dma-masters' is also defined as a uint32 in the Spear 
binding. Types aren't local to a binding, so when there's a 4 byte 
value, is that a phandle or plain uint32? I'm working on a fix in 
dtschema for this. It should be committed shortly.


Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

Rob