linux-kernel - Re: [v4] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <575911ec-aa33-4c5b-877b-8a2bdac08844@arm.com>
Date: Mon, 29 Jul 2024 08:07:55 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Will Deacon <will@...nel.org>, Sedat Dilek <sedat.dilek@...il.com>
Cc: Catalin Marinas <catalin.marinas@....com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [v4] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for
 compressed kernel image



On 7/28/24 01:27, Will Deacon wrote:
> On Fri, Jul 26, 2024 at 10:09:30PM +0200, Sedat Dilek wrote:
>> The COMPRESSED_INSTALL kconfig does not sound very meaningful.
>>
>> Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL.
>>
>> Fixes: commit 4c7be57f2 ("arm64: allow installing compressed image by default")

"Fixes:" tag should only be used for patches that fix real functional
problems in the code.

>> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
>> ---
>>  arch/arm64/Kconfig  | 6 +++---
>>  arch/arm64/Makefile | 6 +++---
>>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> Hmm, I'm not sure I see the point of this tbh. I think the code is fine
> as it is.

Agreed, only thing this patch does is to add "kernel image" prefix
in the config as well in related descriptions which in itself does
not make this any better. As Will mentioned, it is better to leave
this unchanged.