[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <91004ef6-7904-412c-bc3b-28a50b704579@kernel.org>
Date: Mon, 29 Jul 2024 17:07:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dang Huynh <danct12@...eup.net>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch
and Camera Button
On 25/07/2024 03:42, Dang Huynh wrote:
> The Pro1X has a flip keyboard and a single-state camera button.
>
> Signed-off-by: Dang Huynh <danct12@...eup.net>
> ---
> arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 34 +++++++++++++++++++++++--
> 1 file changed, 32 insertions(+), 2 deletions(-)
>
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
Powered by blists - more mailing lists