linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c6bb89e-a9d8-4d5c-837a-30f3bae56f0f@kernel.org>
Date: Mon, 29 Jul 2024 17:10:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: Clark Wang <xiaoning.wang@....com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi

On 29/07/2024 11:45, Alexander Stein wrote:
> From: Clark Wang <xiaoning.wang@....com>
> 
> Add DMA configurations for LPSPI nodes on i.MX8QX/QM/DXL.
> 
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> Using the DMA configuration bits from downstream kernel.
> Tested on TQMa8XxS.
> 
>  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index 1ee9496c988c5..8ae5f065b4180 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -34,6 +34,8 @@ lpspi0: spi@...00000 {
>  		assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>;
>  		assigned-clock-rates = <60000000>;
>  		power-domains = <&pd IMX_SC_R_SPI_0>;
> +		dma-names = "tx","rx";

Missing spaces. Unexpected order, unless that's the coding style for imx.

Best regards,
Krzysztof