linux-kernel - Re: [PATCH v3 2/2] media: qcom: camss: Fix ordering of pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a60057-6fec-49d1-8ff6-71b6fa670f2c@somainline.org>
Date: Mon, 29 Jul 2024 17:17:25 +0200
From: Konrad Dybcio <konrad.dybcio@...ainline.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
 <hansverk@...co.com>, Hans Verkuil <hverkuil-cisco@...all.nl>,
 Milen Mitkov <quic_mmitkov@...cinc.com>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
 Johan Hovold <johan+linaro@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH v3 2/2] media: qcom: camss: Fix ordering of
 pm_runtime_enable



On 29.07.2024 2:42 PM, Bryan O'Donoghue wrote:
> pm_runtime_enable() should happen prior to vfe_get() since vfe_get() calls
> pm_runtime_resume_and_get().
> 
> This is a basic race condition that doesn't show up for most users so is
> not widely reported. If you blacklist qcom-camss in modules.d and then
> subsequently modprobe the module post-boot it is possible to reliably show
> this error up.
> 
> The kernel log for this error looks like this:
> 
> qcom-camss ac5a000.camss: Failed to power up pipeline: -13
> 
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Reported-by: Johan Hovold <johan+linaro@...nel.org>
> Closes: https://lore.kernel.org/lkml/ZoVNHOTI0PKMNt4_@hovoldconsulting.com/
> Tested-by: Johan Hovold <johan+linaro@...nel.org>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---

Reviewed-by: Konrad Dybcio <konradybcio@...nel.org>

Konrad