[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ec63657f-93d1-919b-f87f-eebb13c8938e@linux.intel.com>
Date: Mon, 29 Jul 2024 20:00:34 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Luis Felipe Hernandez <luis.hernandez093@...il.com>
cc: W_Armin@....de, corbet@....net, platform-driver-x86@...r.kernel.org,
linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] wmi: Fix spelling
On Mon, 29 Jul 2024, Luis Felipe Hernandez wrote:
Thanks for this change but please don't leave the commit message empty,
it's not enough to provide just the shortlog (in subject) even if the
change is obvious/simple. Please resubmit this with the commit message
included.
--
i.
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@...il.com>
> ---
> Documentation/wmi/devices/msi-wmi-platform.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/wmi/devices/msi-wmi-platform.rst b/Documentation/wmi/devices/msi-wmi-platform.rst
> index 29b1b2e6d42c..31a136942892 100644
> --- a/Documentation/wmi/devices/msi-wmi-platform.rst
> +++ b/Documentation/wmi/devices/msi-wmi-platform.rst
> @@ -130,12 +130,12 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>
> Due to a peculiarity in how Windows handles the ``CreateByteField()`` ACPI operator (errors only
> happen when a invalid byte field is ultimately accessed), all methods require a 32 byte input
> -buffer, even if the Binay MOF says otherwise.
> +buffer, even if the Binary MOF says otherwise.
>
> The input buffer contains a single byte to select the subfeature to be accessed and 31 bytes of
> input data, the meaning of which depends on the subfeature being accessed.
>
> -The output buffer contains a singe byte which signals success or failure (``0x00`` on failure)
> +The output buffer contains a single byte which signals success or failure (``0x00`` on failure)
> and 31 bytes of output data, the meaning if which depends on the subfeature being accessed.
>
> WMI method Get_EC()
> @@ -147,7 +147,7 @@ data contains a flag byte and a 28 byte controller firmware version string.
> The first 4 bits of the flag byte contain the minor version of the embedded controller interface,
> with the next 2 bits containing the major version of the embedded controller interface.
>
> -The 7th bit signals if the embedded controller page chaged (exact meaning is unknown), and the
> +The 7th bit signals if the embedded controller page changed (exact meaning is unknown), and the
> last bit signals if the platform is a Tigerlake platform.
>
> The MSI software seems to only use this interface when the last bit is set.
>
Powered by blists - more mailing lists