linux-kernel - Re: [PATCH bpf-next v2 3/3] selftests/bpf: add wrong type test to cgroup dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b729c275-b1c4-4435-9d4c-6147b6a4675d@oracle.com>
Date: Mon, 29 Jul 2024 18:40:17 +0100
From: Alan Maguire <alan.maguire@...cle.com>
To: Alexis Lothoré (eBPF Foundation)
 <alexis.lothore@...tlin.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>,
        Yonghong Song <yonghong.song@...ux.dev>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>
Cc: ebpf@...uxfoundation.org, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 3/3] selftests/bpf: add wrong type test to
 cgroup dev

On 29/07/2024 09:20, Alexis Lothoré (eBPF Foundation) wrote:
> Current cgroup_dev test mostly tests that device operation is accepted or
> refused base on passed major/minor (and so, any operation performed during
> test involves only char device)
> 
> Add a small subtest ensuring that the device type passed to bpf program
> allows it to take decisions as well.
> 
> Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@...tlin.com>

Reviewed-by: Alan Maguire <alan.maguire@...cle.com>

> ---
> Changes in v2:
> - change test name ("null" block device does not make sense)
> - use updated subtest API for this new subtest
> ---
>  tools/testing/selftests/bpf/prog_tests/cgroup_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup_dev.c b/tools/testing/selftests/bpf/prog_tests/cgroup_dev.c
> index af0b70086c21..a840973c87b1 100644
> --- a/tools/testing/selftests/bpf/prog_tests/cgroup_dev.c
> +++ b/tools/testing/selftests/bpf/prog_tests/cgroup_dev.c
> @@ -91,6 +91,9 @@ void test_cgroup_dev(void)
>  	if (test__start_subtest("allow-mknod"))
>  		test_mknod("/dev/test_dev_cgroup_null", S_IFCHR, 1, 3, 0);
>  
> +	if (test__start_subtest("deny-mknod-wrong-type"))
> +		test_mknod("/dev/test_dev_cgroup_block", S_IFBLK, 1, 3, -EPERM);
> +
>  	if (test__start_subtest("allow-read"))
>  		test_read("/dev/urandom", buf, TEST_BUFFER_SIZE, TEST_BUFFER_SIZE);
>  
>