linux-kernel - Re: [PATCH] usb: gadget: dummy_hcd: execute hrtimer callback in softirq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4ed3fb2-0d59-4376-af12-de4cd2167b18@rowland.harvard.edu>
Date: Mon, 29 Jul 2024 14:01:22 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Andrey Konovalov <andreyknvl@...il.com>
Cc: Marcello Sylvester Bauer <sylv@...v.io>, andrey.konovalov@...ux.dev,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Aleksandr Nogikh <nogikh@...gle.com>,
	Marco Elver <elver@...gle.com>,
	Alexander Potapenko <glider@...gle.com>, kasan-dev@...glegroups.com,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzbot+2388cdaeb6b10f0c13ac@...kaller.appspotmail.com,
	syzbot+17ca2339e34a1d863aad@...kaller.appspotmail.com,
	stable@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: dummy_hcd: execute hrtimer callback in
 softirq context

On Mon, Jul 29, 2024 at 06:14:30PM +0200, Andrey Konovalov wrote:
> On Mon, Jul 29, 2024 at 10:26 AM Marcello Sylvester Bauer <sylv@...v.io> wrote:
> >
> > Hi Andrey,
> 
> Hi Marcello,
> 
> > Thanks for investigating and finding the cause of this problem. I have
> > already submitted an identical patch to change the hrtimer to softirq:
> > https://lkml.org/lkml/2024/6/26/969
> 
> Ah, I missed that, that's great!
> 
> > However, your commit messages contain more useful information about the
> > problem at hand. So I'm happy to drop my patch in favor of yours.
> 
> That's very considerate, thank you. I'll leave this up to Greg - I
> don't mind using either patch.
> 
> > Btw, the same problem has also been reported by the intel kernel test
> > robot. So we should add additional tags to mark this patch as the fix.
> >
> >
> > Reported-by: kernel test robot <oliver.sang@...el.com>
> > Closes:
> > https://lore.kernel.org/oe-lkp/202406141323.413a90d2-lkp@intel.com
> > Acked-by: Marcello Sylvester Bauer <sylv@...v.io>
> 
> Let's also add the syzbot reports mentioned in your patch:
> 
> Reported-by: syzbot+c793a7eca38803212c61@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c793a7eca38803212c61
> Reported-by: syzbot+1e6e0b916b211bee1bd6@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1e6e0b916b211bee1bd6
> 
> And I also found one more:
> 
> Reported-by: syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=edd9fe0d3a65b14588d5

You need to be careful about claiming that this patch will fix those bug 
reports.  At least one of them (the last one above) still fails with the 
patch applied.  See:

https://lore.kernel.org/linux-usb/ade15714-6aa3-4988-8b45-719fc9d74727@rowland.harvard.edu/

and the following response.

Alan Stern