linux-kernel - Re: [PATCH] selftests: ksft: Track skipped tests when finishing the test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bb2d338-cd00-4ac2-b8bd-5579eae82637@linuxfoundation.org>
Date: Mon, 29 Jul 2024 14:06:41 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: gregkh@...uxfoundation.org, kernel@...labora.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 nfraprado@...labora.com, shuah@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: ksft: Track skipped tests when finishing the
 test suite

On 7/29/24 08:52, Laura Nao wrote:
> Hi Shuah,
> 
> On 7/23/24 18:17, Shuah Khan wrote:
>> On 7/22/24 09:43, Laura Nao wrote:
>>> Consider skipped tests in addition to passed tests when evaluating the
>>> overall result of the test suite in the finished() helper.
>>>

I am finally with you now. Can you please more information in your
short log and commit log.

Isn't this a bug fix? Current logic before this change will report
tests failed if there are any skipped tests?

Can you send v2 calling it a fix and explain the problem clearly.

This isn't problem in this patch, but I am concerned about how
simply calling tests passed without calling out skipped tests.

This problem could be solved by printing a message at the end of tests
for non-zero skipped test conditions to say the coverage could be
increased by enabling config options.

thanks,
-- Shuah