linux-kernel - RE: [PATCH v2] Drivers: hv: vmbus: Optimize boot time by concurrent execution of hv_synic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR21MB1317E317DE46E7F5DB8364BFBFB72@SA1PR21MB1317.namprd21.prod.outlook.com>
Date: Mon, 29 Jul 2024 20:17:21 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Saurabh Sengar <ssengar@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Saurabh Singh Sengar <ssengar@...rosoft.com>, "srivatsa@...il.mit.edu"
	<srivatsa@...il.mit.edu>
Subject: RE: [PATCH v2] Drivers: hv: vmbus: Optimize boot time by concurrent
 execution of hv_synic_init()

> From: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Sent: Monday, July 29, 2024 12:57 AM
>  [...]
> +	/* register the callback for hotplug CPUs */
> +	ret =
> cpuhp_setup_state_nocalls_cpuslocked(CPUHP_AP_ONLINE_DYN,
> "hyperv/vmbus:online",

AFAIK, Hyper-V doesn't support vCPU "hotplug" for VMs; it does
support vCPU online/offline'ing.

To be more accurate, I suggested the comment below instead.
/* Register the callbacks for possible CPU online/offline'ing */

Otherwise, LGTM
Reviewed-by: Dexuan Cui <decui@...rosoft.com>