linux-kernel - Re: [PATCH v11 25/27] ARM: dts: aspeed: yosemite4: add RTQ6056 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqgRq4h0HWClxSEW@heinlein.vulture-banana.ts.net>
Date: Mon, 29 Jul 2024 17:03:23 -0500
From: Patrick Williams <patrick@...cx.xyz>
To: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 25/27] ARM: dts: aspeed: yosemite4: add RTQ6056
 support

On Tue, Jul 23, 2024 at 05:23:06PM +0800, Delphine CC Chiu wrote:
> Add RTQ6056 (spider board 3rd source) support in yosemite4 DTS.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> ---
>  .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts  | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index f73719b3c2f1..03a1e41312e3 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -1240,35 +1240,35 @@ adc@37 {
>  	};
>  
>  	power-sensor@40 {
> -		compatible = "ti,ina233";
> +		compatible = "ti,ina233", "richtek,rtq6056";

Is this legal to have two chips both listed as compatible?  I thought
this approach has been rejected before.

>  		reg = <0x40>;
>  		resistor-calibration = /bits/ 16 <0x0a00>;
>  		current-lsb= /bits/ 16 <0x0001>;
>  	};
>  
>  	power-sensor@41 {
> -		compatible = "ti,ina233";
> +		compatible = "ti,ina233", "richtek,rtq6056";
>  		reg = <0x41>;
>  		resistor-calibration = /bits/ 16 <0x0a00>;
>  		current-lsb= /bits/ 16 <0x0001>;
>  	};
>  
>  	power-sensor@42 {
> -		compatible = "ti,ina233";
> +		compatible = "ti,ina233", "richtek,rtq6056";
>  		reg = <0x42>;
>  		resistor-calibration = /bits/ 16 <0x0a00>;
>  		current-lsb= /bits/ 16 <0x0001>;
>  	};
>  
>  	power-sensor@43 {
> -		compatible = "ti,ina233";
> +		compatible = "ti,ina233", "richtek,rtq6056";
>  		reg = <0x43>;
>  		resistor-calibration = /bits/ 16 <0x0a00>;
>  		current-lsb= /bits/ 16 <0x0001>;
>  	};
>  
>  	power-sensor@44 {
> -		compatible = "ti,ina233";
> +		compatible = "ti,ina233", "richtek,rtq6056";
>  		reg = <0x44>;
>  		resistor-calibration = /bits/ 16 <0x0a00>;
>  		current-lsb= /bits/ 16 <0x0001>;
> -- 
> 2.25.1
> 

-- 
Patrick Williams

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)