linux-kernel - Re: linux-next: build warnings after merge of the origin tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wi3+tK5ndB0P3Yi2HOYFm6YMc-k-wBJjTEo__opsp51jg@mail.gmail.com>
Date: Mon, 29 Jul 2024 16:57:42 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the origin tree

On Mon, 29 Jul 2024 at 16:38, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Does anybody have a clue-bat: what makes only the powerpc build show
> this valid warning?

The obvious fix to just remove the stale static variables has been pushed out.

And it turns out I see the failure too, if I use clang.

Interestingly, clang did *not* complain about the

  static DEFINE_MUTEX(profile_flip_mutex);

only about the static DEFINE_PER_CPU() cases.

So it looks like having an initializer ends up suppressing the
message, probably due to various historical usage patterns (eg things
like

   static char *rcsid="$Id...";

which is a common traditional pattern).

I have the same gcc version on both arm64 and x86-64, so I guess it
could also be some gcc version dependency that caused me to not see
it.

           Linus