linux-kernel - Re: [PATCH v5 1/2] drm/loongson: Introduce component framework support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dbe975a-59eb-4d4b-9fea-b930fa44e4ec@web.de>
Date: Mon, 29 Jul 2024 08:40:46 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>, dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH v5 1/2] drm/loongson: Introduce component framework
 support

…
> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
> @@ -0,0 +1,108 @@
…
> +#ifndef __LOONGSON_DRV_H__
> +#define __LOONGSON_DRV_H__
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus