linux-kernel - Re: [PATCH] media: imx335: Fix reset-gpio handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqdHpx7k6gzf-jSb@kekkonen.localdomain>
Date: Mon, 29 Jul 2024 07:41:27 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Umang Jain <umang.jain@...asonboard.com>
Cc: linux-media@...r.kernel.org,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	open list <linux-kernel@...r.kernel.org>,
	Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH] media: imx335: Fix reset-gpio handling

Hi Umang,

Thanks for the patch.

On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
> The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.

Should it be initialised to high instead, to enable reset?

I think you should also add a Fixes: tag to this and Cc: stable.

> However, the reset-gpio logical value is set to 1 in during power-on
> and to 0 on power-off. This is incorrect as the reset line
> cannot be high during power-on and low during power-off.
> 
> Rectify the logical value of reset-gpio so that it is set to
> 0 during power-on and to 1 during power-off.
> 
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>

-- 
Kind regards,

Sakari Ailus