linux-kernel - Re: [PATCH 5/5] soc: mediatek: mtk-pmic-wrap: Drop CAP reset in MT6765

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cc155fd-c4e6-4c5c-b3c2-d1a3e7b70bf9@collabora.com>
Date: Mon, 29 Jul 2024 09:48:38 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Arseniy Velikanov <me@...merle.xyz>, mturquette@...libre.com,
 sboyd@...nel.org, matthias.bgg@...il.com, sean.wang@...nel.org,
 linus.walleij@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, frank.li@...o.com, jiasheng@...as.ac.cn,
 mars.cheng@...iatek.com, owen.chen@...iatek.com, macpaul.lin@...iatek.com,
 zh.chen@...iatek.com, argus.lin@...iatek.com
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 5/5] soc: mediatek: mtk-pmic-wrap: Drop CAP reset in
 MT6765

Il 29/07/24 09:34, Arseniy Velikanov ha scritto:
> None of the MT6765 reset-controllers have PWRAP reset,
> so remove the requirement of it

Sorry, but that's not true. There is indeed a reset bit for the PWRAP on MT6765.

Which one and where - I have no idea, but I'm sure that there is one :-)

Cheers,
Angelo

> 
> Fixes: 12b079b0fe8b ("soc: mediatek: pwrap: add pwrap driver for mt6765 SoCs")
> Signed-off-by: Arseniy Velikanov <me@...merle.xyz>
> ---
>   drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index efd9cae212dc..30d74279e27f 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2288,7 +2288,7 @@ static const struct pmic_wrapper_type pwrap_mt6765 = {
>   	.int_en_all = 0xffffffff,
>   	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>   	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
> -	.caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
> +	.caps = PWRAP_CAP_DCM,
>   	.init_reg_clock = pwrap_common_init_reg_clock,
>   	.init_soc_specific = NULL,
>   };