linux-kernel - Re: [PATCH] power: sequencing: pwrseq-qcom-wcn: Depend on WCN36XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcop3+00G3kZo+dazpemuj0PjXNc_3+EiyFukLevBGd_A@mail.gmail.com>
Date: Mon, 29 Jul 2024 10:12:27 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: sequencing: pwrseq-qcom-wcn: Depend on WCN36XX

On Thu, Jul 25, 2024 at 6:28 PM Andrew Halaney <ahalaney@...hat.com> wrote:
>
> This driver does sequencing for the hardware driven by WCN36XX, let's
> make it depend on that. Without WCN36XX, we're sequencing power for
> nothing.
>
> Fixes: 2f1630f437df ("power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets")
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
> ---
> I *think* this makes sense, but if you disagree please let me know. I
> was sorting out configs in fedora and noticed this was being asked for
> builds that didn't have WCN36XX enabled, which seems odd to me at least.
> ---
>  drivers/power/sequencing/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/sequencing/Kconfig b/drivers/power/sequencing/Kconfig
> index c9f1cdb665248..a4765cb33a80e 100644
> --- a/drivers/power/sequencing/Kconfig
> +++ b/drivers/power/sequencing/Kconfig
> @@ -16,6 +16,7 @@ if POWER_SEQUENCING
>  config POWER_SEQUENCING_QCOM_WCN
>         tristate "Qualcomm WCN family PMU driver"
>         default m if ARCH_QCOM
> +       depends on WCN36XX
>         help
>           Say Y here to enable the power sequencing driver for Qualcomm
>           WCN Bluetooth/WLAN chipsets.
>
> ---
> base-commit: 2347b4c79f5e6cd3f4996e80c2d3c15f53006bf5
> change-id: 20240725-pwrseq-wcn-config-0b6668b5c620
>
> Best regards,
> --
> Andrew Halaney <ahalaney@...hat.com>
>

What if we want to disable the WLAN driver but keep the Bluetooth
driver enabled?

Bart