linux-kernel - Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2050c2e-582f-4c6c-bf5f-54c5abd375cb@leemhuis.info>
Date: Mon, 29 Jul 2024 10:35:28 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Greg KH <gregkh@...uxfoundation.org>, "Lin, Wayne" <Wayne.Lin@....com>
Cc: "stable@...r.kernel.org" <stable@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>,
 ML dri-devel <dri-devel@...ts.freedesktop.org>,
 "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
 "Wu, Hersen" <hersenxs.wu@....com>,
 "Deucher, Alexander" <Alexander.Deucher@....com>,
 "kevin@...m.dev" <kevin@...m.dev>,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [REGRESSION] No image on 4k display port displays connected
 through usb-c dock in kernel 6.10

[+Greg +stable]

On 29.07.24 10:16, Lin, Wayne wrote:
>
> Thanks for the report.
> 
> Patch fa57924c76d995 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()")
> is kind of correcting problems causing by commit:
> 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for mst mode validation")
> 
> Sorry if it misses fixes tag and would suggest to backport to fix it. Thanks!

Greg, seem it would be wise to pick up fa57924c76d995 for 6.10.y as
well, despite a lack of Fixes or stable tags.

Ciao, Thorsten

>> -----Original Message-----
>> From: kevin@...m.dev <kevin@...m.dev>
>> Sent: Sunday, July 28, 2024 12:43 AM
>> To: Linux regressions mailing list <regressions@...ts.linux.dev>; Deucher,
>> Alexander <Alexander.Deucher@....com>; Wu, Hersen
>> <hersenxs.wu@....com>; Lin, Wayne <Wayne.Lin@....com>
>> Cc: regressions@...ts.linux.dev; stable@...r.kernel.org; LKML <linux-
>> kernel@...r.kernel.org>; ML dri-devel <dri-devel@...ts.freedesktop.org>;
>> amd-gfx@...ts.freedesktop.org
>> Subject: Re: [REGRESSION] No image on 4k display port displays connected
>> through usb-c dock in kernel 6.10
>>
>>> [adding a few people and lists to the recipients]
>>>
>>> Hi! Thx for your rpeort.
>>>
>>> On 27.07.24 18:07, kevin@...m.dev wrote:
>>>
>>>>
>>>> Connecting two 4k displays with display port through a lenovo usb-c
>>>>
>>>>  dock (type 40AS) to a Lenovo P14s Gen 2 (type 21A0) results in no
>>>>
>>>>  image on the connected displays.
>>>>
>>>>
>>>>
>>>>  The CPU in the Lenovo P14s is a 'AMD Ryzen 7 PRO 5850U with Radeon
>>>>
>>>>  Graphics' and it has no discrete GPU.
>>>>
>>>>
>>>>
>>>>  I first noticed the issue with kernel version '6.10.0-arch1-2'
>>>>
>>>>  provided by arch linux. With the previous kernel version
>>>>
>>>>  '6.9.10.arch1-1' both connected displays worked normally. I reported
>>>>
>>>>  the issue in the arch forums at
>>>>
>>>>  https://bbs.archlinux.org/viewtopic.php?id=297999 and was guided to
>>>>
>>>>  do a bisection to find the commit that caused the problem. Through
>>>>
>>>>  testing I identified that the issue is not present in the latest
>>>>
>>>>  kernel directly compiled from the trovalds/linux git repository.
>>>>
>>>>
>>>>
>>>>  With git bisect I identified
>> 4df96ba66760345471a85ef7bb29e1cd4e956057
>>>>
>>>
>>> That's 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for
>>>
>>> mst mode validation") [v6.10-rc1] from Hersen Wu.
>>>
>>> Did you try if reverting that commit is possible and might fix the problem?
>>
>> Reverting is not easily possible:
>>
>> $ git checkout v6.10
>> [...]
>> HEAD is now at 0c3836482481 Linux 6.10
>>
>> $ git revert 4df96ba66760345471a85ef7bb29e1cd4e956057
>> Auto-merging
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> CONFLICT (content): Merge conflict in
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> error: could not revert 4df96ba66760... drm/amd/display: Add timing pixel
>> encoding for mst mode validation
>>
>> I do not know enough to try and solve the conflict myself without breaking
>> more things.
>>
>>>
>>>>
>>>> as the first bad commit and
>> fa57924c76d995e87ca3533ec60d1d5e55769a27
>>>>
>>>
>>> That's fa57924c76d995 ("drm/amd/display: Refactor function
>>>
>>> dm_dp_mst_is_port_support_mode()") [v6.10-post] from Wayne Lin.
>>>
>>>>
>>>> as the first commit that fixed the problem again.
>>>>
>>>
>>> Hmm, the latter commit does not have a fixes tag and might or might not
>>>
>>> be to invasive to backport to 6.10. Let's see what the AMD developers say.
>>>
>>>>
>>>> The initial commit only still shows an image on one of the connected
>>>>
>>>>  4k screens. I have not investigated further to find out at what point
>>>>
>>>>  both displays stopped showing an image.
>>>>
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>
>>> --
>>>
>>> Everything you wanna know about Linux kernel regression tracking:
>>>
>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>>
>>> If I did something stupid, please tell me, as explained on that page.
>>>