linux-kernel - Re: [PATCH] media: imx335: Fix reset-gpio handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqdYqaMDWjHrNXPh@kekkonen.localdomain>
Date: Mon, 29 Jul 2024 08:54:01 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Umang Jain <umang.jain@...asonboard.com>
Cc: linux-media@...r.kernel.org,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	open list <linux-kernel@...r.kernel.org>,
	Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH] media: imx335: Fix reset-gpio handling

Hi Umang,

On Mon, Jul 29, 2024 at 02:19:32PM +0530, Umang Jain wrote:
> Hi Sakari
> 
> On 29/07/24 1:11 pm, Sakari Ailus wrote:
> > Hi Umang,
> > 
> > Thanks for the patch.
> > 
> > On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
> > > The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.
> > Should it be initialised to high instead, to enable reset?
> 
> This initialization matches the physical line status, which is low in this
> case.

Documentation/driver-api/gpio/consumer.rst:

	* GPIOD_OUT_LOW to initialize the GPIO as output with a value of 0.

...

	Note that the initial value is *logical* and the physical line
	level depends on whether the line is configured active high or
	active low (see :ref:`active_low_semantics`).

-- 
Sakari Ailus