linux-kernel - Re: [PATCH v4 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <225279b3-882b-4d97-b7f4-08129c1f05a7@broadcom.com>
Date: Mon, 29 Jul 2024 11:01:59 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Jacobe Zang <jacobe.zang@...ion.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "heiko@...ech.de"
 <heiko@...ech.de>, "kvalo@...nel.org" <kvalo@...nel.org>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "efectn@...tonmail.com" <efectn@...tonmail.com>,
 "dsimic@...jaro.org" <dsimic@...jaro.org>,
 "jagan@...eble.ai" <jagan@...eble.ai>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "arend@...adcom.com" <arend@...adcom.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "megi@....cz"
 <megi@....cz>, "duoming@....edu.cn" <duoming@....edu.cn>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "minipli@...ecurity.net" <minipli@...ecurity.net>,
 "brcm80211@...ts.linux.dev" <brcm80211@...ts.linux.dev>,
 "brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>,
 Nick Xie <nick@...das.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: net: wireless: brcm4329-fmac: add
 clock description for AP6275P Wi-Fi device

On 7/29/2024 10:17 AM, Jacobe Zang wrote:
>>> Add clocks and clock-names for brcm4329-fmac.
>>
>> Why? Which devices have it? If only your newest addon, then squash the
>> patches and add appropriate allOf:if:then disallowing the clocks for
>> others. Or maybe all of them have it? Why commit msg does not explain
>> anything about the hardware?
> 
> Alright... Becuase of the datasheet said hardware has one LPO clock input. So
> I will add allOf:if:then for this specific hardware

Maybe this can help clarifying the commit message. All Broadcom wireless 
chips have this clock input, but often the chip end up on a wifi module 
that may or may not provide the clock. From chip perspective the clock 
input is always present, but it is optional as the chip can also use an 
internal clock.

As such I would not choose to make this specific to this AP6275P 
hardware (just my 2 cents).

Regards,
Arend