linux-kernel - Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY for QCS9100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21c86552-4719-4e60-ab7e-9df3d732df46@quicinc.com>
Date: Mon, 29 Jul 2024 17:47:11 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: describe the Qualcomm SGMII PHY
 for QCS9100



On 7/11/2024 11:52 AM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 17:15, Tengfei Fan wrote:
>>> Document the Qualcomm SGMII PHY for the QCS9100 platforms.
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe
>>> non-SCMI based the Qualcomm SGMII PHY.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>> ---
>>>   
>>> .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml        
>>> | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> index b9107759b2a5..74ec4579c0d6 100644
>>> --- 
>>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> +++ 
>>> b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
>>> @@ -15,7 +15,10 @@ description:
>>>   properties:
>>>     compatible:
>>> -    const: qcom,sa8775p-dwmac-sgmii-phy
>>> +    items:
>>
>> items is not needed here, this could be an enum directly.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Thanks Krzysztof!
> 
> In the next version patch series, I will check all the patch series, 
> using an enum instead od items.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 
>>
>>
>>
>> Best regards,
>> Krzysztof
>>
> 

-- 
Thx and BRs,
Tengfei Fan