linux-kernel - Re: [PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f57d80bd-b40c-44fe-b5ae-9b9eaac643e4@quicinc.com>
Date: Mon, 29 Jul 2024 17:56:55 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Simon Horman <horms@...nel.org>
CC: Vinod Koul <vkoul@...nel.org>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        "Paolo
 Abeni" <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bhupesh
 Sharma <bhupesh.sharma@...aro.org>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin
	<mcoquelin.stm32@...il.com>, <kernel@...cinc.com>,
        <netdev@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos
 compatible



On 7/10/2024 3:27 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 1:42 AM, Simon Horman wrote:
>> On Tue, Jul 09, 2024 at 10:13:16PM +0800, Tengfei Fan wrote:
>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>> While the QCS9100 platform is still in the early design stage, the
>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>
>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>> The QCS9100 device tree patches will be pushed after all the device tree
>>> bindings and device driver patches are reviewed.
>>>
>>> The final dtsi will like:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>>
>>> The detailed cover letter reference:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>> ---
>>> Changes in v2:
>>>    - Split huge patch series into different patch series according to
>>>      subsytems
>>>    - Update patch commit message
>>>
>>> prevous disscussion here:
>>> [1] v1: 
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> ---
>>> Tengfei Fan (2):
>>>        dt-bindings: net: qcom,ethqos: add description for qcs9100
>>>        net: stmmac: dwmac-qcom-ethqos: add support for emac4 on 
>>> qcs9100 platforms
>>>
>>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml  | 1 +
>>>   Documentation/devicetree/bindings/net/snps,dwmac.yaml   | 2 ++
>>>   drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
>>>   3 files changed, 4 insertions(+)
>>> ---
>>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
>>
>> I'm assuming that this is a patch for net-next.
>> But the commit above is not present in net-next,
>> and this series doesn't apply to net-next.
>>
>> Please rebase when preparing v3.
>> And please designate the target tree in the subject.
>>
>>     Subject: [PATCH net-next v3] ...
>>
>> Thanks!
> 
> I willmake the correspinding modifications according to your suggestion 
> in the V3 patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 

-- 
Thx and BRs,
Tengfei Fan