linux-kernel - Re: [PATCH] Revert "firmware: qcom: qseecom: convert to using the TZ allocator"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McuqEv1Sk9O6kn4aHo9wOfzskZS0z2QxzNM=q2N8XZ3zw@mail.gmail.com>
Date: Mon, 29 Jul 2024 12:03:55 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: Maximilian Luz <luzmaximilian@...il.com>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Amirreza Zarrabi <quic_azarrabi@...cinc.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Elliot Berman <quic_eberman@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	regressions@...ts.linux.dev
Subject: Re: [PATCH] Revert "firmware: qcom: qseecom: convert to using the TZ allocator"

On Mon, Jul 29, 2024 at 11:58 AM Johan Hovold <johan+linaro@...nel.org> wrote:
>
> This reverts commit 6612103ec35af6058bb85ab24dae28e119b3c055.
>
> Using the "TZ allocator" for qcseecom breaks efivars on machines like
> the Lenovo ThinkPad X13s and x1e80100 CRD:
>
>         qcom_scm firmware:scm: qseecom: scm call failed with error -22
>
> Reverting to the 6.10 state makes qseecom work again.
>
> Fixes: 6612103ec35a ("firmware: qcom: qseecom: convert to using the TZ allocator")
> Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
> Cc: regressions@...ts.linux.dev
>
> #regzbot introduced: 6612103ec35a
>

How about at least giving me the chance to react to the report and fix
it instead of reverting it right away?

Are there any other messages about SHM bridge/SCM calls in the kernel log?

Do you have QCOM_TZMEM_MODE_GENERIC=y or QCOM_TZMEM_MODE_SHM_BRIDGE=y
in your config? If the latter: can you try changing it to the former
and retest?

>
> It's a little frustrating to find that no-one tested this properly or
> even noticed the regression for the past month that this has been
> sitting in linux-next.
>

I have tested many platforms and others have done the same but
unfortunately cannot possibly test every single use-case on every
platform. This is what next is for after all.

> Looks like Maximilian may have hit this with v9 too:
>
>         https://lore.kernel.org/lkml/CAMRc=Mf_pvrh2VMfTVE-ZTypyO010p=to-cd8Q745DzSDXLGFw@mail.gmail.com/
>
> even if there were further issues with that revision.

This is a different issue that was fixed in a later iteration.

>
> Johan
>

Bartosz