linux-kernel - Re: [PATCH v2] dt-bindings: crypto: ice: Document QCS9100 inline crypto engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7be1d1d-3b6f-4a75-b5f6-429b25f84e63@quicinc.com>
Date: Mon, 29 Jul 2024 18:26:55 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Herbert Xu
	<herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, Maria Yu <quic_aiquny@...cinc.com>
Subject: Re: [PATCH v2] dt-bindings: crypto: ice: Document QCS9100 inline
 crypto engine



On 7/10/2024 6:23 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:16 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 15:08, Tengfei Fan wrote:
>>> Document the compatible used for the inline crypto engine found on
>>> QCS9100.
>>>
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
>>> describe non-SCMI based crypto engine.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>> ---
>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>> While the QCS9100 platform is still in the early design stage, the
>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>
>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>> The QCS9100 device tree patches will be pushed after all the device tree
>>> bindings and device driver patches are reviewed.
>>>
>>> The final dtsi will like:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>> The detailed cover letter reference:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> Co-developed-by: Maria Yu <quic_aiquny@...cinc.com>
>>> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>
>>
>> This looks messy - wrongly placed, not in correct DCO order. Some tools
>> will just ignore it, some might produce wrong result.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Thanks Krzysztof!
> 
> I will fix the messy information in all the QCS9100 related patch series 
> in the next.
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore the current patche here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan