linux-kernel - Re: [PATCH v4 2/3] ARM: Fix crash memory reserve exceed system memory bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zqd5joQ/hB8wfebg@shell.armlinux.org.uk>
Date: Mon, 29 Jul 2024 12:14:22 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, hpa@...or.com, arnd@...db.de,
	gregkh@...uxfoundation.org, deller@....de, javierm@...hat.com,
	bhe@...hat.com, robh@...nel.org, alexghiti@...osinc.com,
	bjorn@...osinc.com, akpm@...ux-foundation.org, namcao@...utronix.de,
	dawei.li@...ngroup.cn, chenjiahao16@...wei.com, rppt@...nel.org,
	julian.stecklina@...erus-technology.de, rafael.j.wysocki@...el.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] ARM: Fix crash memory reserve exceed system
 memory bug

On Mon, Jul 22, 2024 at 11:57:00AM +0800, Jinjie Ruan wrote:
> Similar with x86_32, on Qemu vexpress-a9 with 1GB memory, the crash kernel
> "crashkernel=4G" is ok as below:
> 	Reserving 4096MB of memory at 2432MB for crashkernel (System RAM: 1024MB)
> 
> The cause is that the crash_size is parsed and printed with "unsigned long
> long" data type which is 8 bytes but allocated used with "phys_addr_t"
> which is 4 bytes in memblock_phys_alloc_range().
> 
> Fix it by checking if the crash_size is greater than system RAM size and
> warn out as parse_crashkernel_mem() do it if so as Baoquan suggested.
> 
> After this patch, it fails and there is no above confusing reserve
> success info.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> Suggested-by: Baoquan He <bhe@...hat.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!