linux-kernel - RE: [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a00539c18c894f0192bea94b48fcfa69@realtek.com>
Date: Mon, 29 Jul 2024 11:31:52 +0000
From: Justin Lai <justinlai0215@...ltek.com>
To: Markus Elfring <Markus.Elfring@....de>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        "David
 S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, "Jiri
 Pirko" <jiri@...nulli.us>,
        Joe Damato <jdamato@...tly.com>, Larry Chiu
	<larry.chiu@...ltek.com>,
        Paolo Abeni <pabeni@...hat.com>, Ping-Ke Shih
	<pkshih@...ltek.com>,
        Ratheesh Kannoth <rkannoth@...vell.com>,
        Simon Horman
	<horms@...nel.org>
Subject: RE: [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module

> > +++ b/drivers/net/ethernet/realtek/rtase/rtase.h
> > @@ -0,0 +1,338 @@
> …
> > +#ifndef _RTASE_H_
> > +#define _RTASE_H_
> …
> 
> I suggest to omit leading underscores from such identifiers.
> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+d
> efine+a+reserved+identifier
> 
> Regards,
> Markus

Hi Markus,

Thank you for your response, I will modify it.

Justin