linux-kernel - Re: [PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240729-abgeordnete-attest-d20071dfb242@brauner>
Date: Mon, 29 Jul 2024 14:18:02 +0200
From: Christian Brauner <brauner@...nel.org>
To: Jan Kara <jack@...e.cz>
Cc: mohitpawar@...aoe.ac.in, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed: fs: file_table_c: Missing blank line warnings and
 struct declaration improved

On Mon, Jul 29, 2024 at 01:49:59PM GMT, Jan Kara wrote:
> On Sat 27-07-24 12:51:34, mohitpawar@...aoe.ac.in wrote:
> > From: Mohit0404 <mohitpawar@...aoe.ac.in>
> > 
> > Fixed-
> > 	WARNING: Missing a blank line after declarations
> > 	WARNING: Missing a blank line after declarations
> > 	Declaration format: improved struct file declaration format
> > 
> > Signed-off-by: Mohit0404 <mohitpawar@...aoe.ac.in>
> > ---
> >  fs/file_table.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/file_table.c b/fs/file_table.c
> > index ca7843dde56d..306d57623447 100644
> > --- a/fs/file_table.c
> > +++ b/fs/file_table.c
> > @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
> >  	register_sysctl_init("fs", fs_stat_sysctls);
> >  	if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
> >  		struct ctl_table_header *hdr;
> > +
> >  		hdr = register_sysctl_mount_point("fs/binfmt_misc");
> >  		kmemleak_not_leak(hdr);
> >  	}
> > @@ -383,7 +384,10 @@ EXPORT_SYMBOL_GPL(alloc_file_pseudo_noaccount);
> >  struct file *alloc_file_clone(struct file *base, int flags,
> >  				const struct file_operations *fops)
> >  {
> > -	struct file *f = alloc_file(&base->f_path, flags, fops);
> > +	struct file *f;
> > +
> > +	f = alloc_file(&base->f_path, flags, fops);
> > +
> 
> When you separated the function call from the declaration of 'f' this empty
> line is superfluous. Maybe Christian can fix it up in his tree (or maybe he
> already did). Otherwise the patch looks good. Feel free to add:

I already did. :)