[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b5edd9f8-4764-41e3-a4ea-5d9838acd5f9@kernel.org>
Date: Mon, 29 Jul 2024 14:28:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alex Lanzano <lanzano.alex@...il.com>,
Markus Elfring <Markus.Elfring@....de>
Cc: Mehdi Djait <mehdi.djait@...tlin.com>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
Christophe Jaillet <christophe.jaillet@...adoo.fr>,
Conor Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...il.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Rob Herring <robh@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD
On 29/07/2024 14:05, Alex Lanzano wrote:
>> Under which circumstances would you become interested to apply a statement
>> like “guard(mutex)(&smd->tx_mutex);”?
>> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196
>>
>
> Ah, I didn't realize guarded mutexes were implemented. That's really
> good to know.
>
> I'd usually use them when it's possible to return before mutex_unlock is
> called to avoid goto cleanup logic. But it's probably best to just use them
> by default.
>
> Thanks for the review. Will clean up in v4.
<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.
</form letter>
Best regards,
Krzysztof
Powered by blists - more mailing lists