linux-kernel - Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cymw8j2e.ffs@tglx>
Date: Mon, 29 Jul 2024 14:43:37 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Chen Yu <yu.c.chen@...el.com>, Dave Hansen
 <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, Borislav
 Petkov <bp@...en8.de>
Cc: "H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>,
 virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org, Juergen
 Gross <jgross@...e.com>, Nikolay Borisov <nik.borisov@...e.com>, Qiuxu
 Zhuo <qiuxu.zhuo@...el.com>, Chen Yu <yu.c.chen@...el.com>, Prem Nath Dey
 <prem.nath.dey@...el.com>, Xiaoping Zhou <xiaoping.zhou@...el.com>
Subject: Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

On Mon, Jul 29 2024 at 14:52, Chen Yu wrote:
>  #ifdef CONFIG_PARAVIRT
>  /*
> - * virt_spin_lock_key - enables (by default) the virt_spin_lock() hijack.
> + * virt_spin_lock_key - disables (by default) the virt_spin_lock() hijack.
>   *
>   * Native (and PV wanting native due to vCPU pinning) should disable this key.
>   * It is done in this backwards fashion to only have a single direction change,
>   * which removes ordering between native_pv_spin_init() and HV setup.

This comment is bogus now.