linux-kernel - Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e10605a-e45b-b683-afe1-27c2e3a51b4c@huawei.com>
Date: Mon, 29 Jul 2024 10:36:57 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Thomas Gleixner <tglx@...utronix.de>, <maz@...nel.org>,
	<joey.gouly@....com>, <mark.rutland@....com>, <will@...nel.org>,
	<catalin.marinas@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq()



On 2024/7/27 17:25, Thomas Gleixner wrote:
> On Sat, Jul 27 2024 at 15:36, Jinjie Ruan wrote:
>> Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"),
>> the gic_handle_irq() is only called by C functions, so remove
>> the asmlinkage.
>>
>> Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> 
> Right. Can we please fix all of that and be done with it?
> 
> # git grep -l asmlinkage drivers/irqchip/ | xargs grep set_handle_irq
> 
> should find the remaining leftovers of asmlinkage.

You are right，handle_arch_irq() are all only called in C now, we can all
remove the asmlinkage.

> 
> Thanks,
> 
>         tglx