linux-kernel - Re: [PATCH v2] staging: rtl8723bs: style fix open brace on new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad55619f-f663-4bc2-ae73-aae7dcaa4272@suswa.mountain>
Date: Tue, 30 Jul 2024 09:46:56 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Sai Sree Kartheek Adivi <sskartheekadivi@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht, helen.koike@...labora.com
Subject: Re: [PATCH v2] staging: rtl8723bs: style fix open brace on new line

On Tue, Jul 30, 2024 at 06:59:01AM +0000, Sai Sree Kartheek Adivi wrote:
> It fixes the following checkpatch.pl error
> "ERROR: that open brace { should be on the previous line" and avoids the
> warning "WARNING: braces {} are not necessary for single statement blocks".
> 
> Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@...il.com>
> ---
> Updated the commit message.
> This is my first contribution. Hope I did everything right!
> 

The only thing you didn't do was explain what changed between v1 and v2.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Please send a v3 patch.

regards,
dan carpenter