[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240730074826.3b1c6948@kernel.org>
Date: Tue, 30 Jul 2024 07:48:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Florian Westphal <fw@...len.de>, Breno Leitao <leitao@...ian.org>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, leit@...a.com, Chris Mason <clm@...com>, "open
list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref
when debugging
On Tue, 30 Jul 2024 16:37:10 +0200 Paolo Abeni wrote:
> I think that better specifying the general guidance/expectation should
> be enough. What about extending the knob description with something alike:
> ---
> diff --git a/net/Kconfig.debug b/net/Kconfig.debug
> index 5e3fffe707dd..058cf031913b 100644
> --- a/net/Kconfig.debug
> +++ b/net/Kconfig.debug
> @@ -24,3 +24,5 @@ config DEBUG_NET
> help
> Enable extra sanity checks in networking.
> This is mostly used by fuzzers, but is safe to select.
> + This could introduce some very minimal overhead and
> + is not suggested for production systems.
I'd go with:
Enable extra sanity checks in networking.
- This is mostly used by fuzzers, but is safe to select.
+ This is mostly used by fuzzers, and may introduce some
+ minimal overhead, but is safe to select.
What's acceptable on prod systems really depends on the workload..
Powered by blists - more mailing lists