linux-kernel - Re: [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240730145956.n7brt337sc5vjpg5@violet>
Date: Tue, 30 Jul 2024 09:59:56 -0500
From: Nishanth Menon <nm@...com>
To: Jared McArthur <j-mcarthur@...com>
CC: Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Tero Kristo <kristo@...nel.org>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for
 mcu_gpio0

On 09:33-20240730, Jared McArthur wrote:
> Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
> properties") introduced pinmux range definition for gpio-ranges,
> however missed introducing the range description for the mcu_gpio0
> node. As a result, automatic mapping of GPIO to pin control for mcu
> gpios is broken. Fix this by introducing the proper ranges.
> 
> Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
> Signed-off-by: Jared McArthur <j-mcarthur@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index e65db6ce02bf..c0bdbd00dc23 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> @@ -146,6 +146,9 @@ mcu_gpio0: gpio@...1000 {
>  		power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
>  		clocks = <&k3_clks 79 0>;
>  		clock-names = "gpio";
> +		gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>,
> +			      <&mcu_pmx0 22 32 2>;
> +		ti,ngpio = <24>;

we already have ti,ngpio - please drop

>  	};
>  
>  	mcu_rti0: watchdog@...0000 {
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D