linux-kernel - Re: [PATCH] dt-bindings: clock: nxp,lpc3220-clk: Convert bindings to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159a9d77-5038-4691-8246-e10d3b49e26a@kernel.org>
Date: Tue, 30 Jul 2024 17:57:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: nxp,lpc3220-clk: Convert bindings to
 DT schema

On 29/07/2024 21:37, Animesh Agarwal wrote:
> Convert the NXP LPC32xx Clock Controller bindings to yaml format.
> 
> Cc: Daniel Baluta <daniel.baluta@....com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>

> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-clk
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    description: Phandles of external oscillators, the list must contain one
> +      32768 Hz oscillator and may have one optional high frequency oscillator.
> +    maxItems: 2

That's not correct and does not match clock-names. List the items with
description instead of above "phandles ...." and add minItems.


> +
> +  clock-names:
> +    oneOf:

Drop. It's:

minItems: 1
items:
 - const: ...
 - const:

> +      - items:
> +          - const: xtal_32k
> +          - const: xtal
> +      - const: xtal_32k
> +


Best regards,
Krzysztof