linux-kernel - Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqkTVygxG8cJULbt@makrotopia.org>
Date: Tue, 30 Jul 2024 17:22:47 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: arinc.unal@...nc9.com,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Linux regressions mailing list <regressions@...ts.linux.dev>,
	Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, frank-w@...lic-files.de,
	Frank Wunderlich <linux@...web.de>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

Hi,

On Tue, Jul 30, 2024 at 06:04:12PM +0200, Krzysztof Kozlowski wrote:
> On 30/07/2024 13:22, arinc.unal@...nc9.com wrote:
> > [...]
> > In my view, your behaviour of not applying a devicetree patch before a
> > Linux driver patch was applied, and then not replying to any arguments
> > whatsoever, was keeping the devicetree files hostage until your demands
> 
> Hm, why ever DTS patch should be applied before driver patch is? This
> clearly suggests ABI break. You proposed to fix ABI issue by fixing DTS,
> which is not the way, because it literally fixes nothing. You got
> comments - fix the driver to be backwards compatible.

I've suggested a fix for the driver here:

https://patchwork.kernel.org/project/netdevbpf/patch/f485d1d4f7b34cc2ebf3d60030d1c67b4016af3c.1720107535.git.daniel@makrotopia.org/

It has been tested and acknowledged by Arinc, hence a possible solution
would be to apply it and there by restore compatibility with existing
(broken) device trees.