linux-kernel - Re: [PATCH v6 02/27] dt-bindings: mfd: syscon: add microchip's sam9x7 sfr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240730165002.GA1508552-robh@kernel.org>
Date: Tue, 30 Jul 2024 10:50:02 -0600
From: Rob Herring <robh@...nel.org>
To: Varshini Rajendran <varshini.rajendran@...rochip.com>
Cc: lee@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
	ychuang3@...oton.com, schung@...oton.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v6 02/27] dt-bindings: mfd: syscon: add microchip's
 sam9x7 sfr

On Mon, Jul 29, 2024 at 12:36:03PM +0530, Varshini Rajendran wrote:
> Add compatible for sam9x7 SoC's SFR.

That's (kind of) obvious from the diff. How is the block on the new SoC 
the same or different from the prior chip? It's kind of strange that one 
of these blocks which tend to be register bit soup of left over controls 
would be the same or a superset of another SoC.

> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
> Changes in v6:
> 
>  - New patch in v6 as the syscon devices are moved to a new file
>    upstream.
> ---
>  .../devicetree/bindings/mfd/syscon.yaml       | 188 +++++++++---------
>  1 file changed, 97 insertions(+), 91 deletions(-)

Put this in your own schema file. I don't think we want get into more 
complicated cases here.

Rob