linux-kernel - Re: [PATCH v5 1/2] drm/loongson: Introduce component framework support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b34fb4c-abde-47e8-984b-3ea55d4475a7@linux.dev>
Date: Wed, 31 Jul 2024 01:46:36 +0800
From: Sui Jingfeng <sui.jingfeng@...ux.dev>
To: Markus Elfring <Markus.Elfring@....de>, dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH v5 1/2] drm/loongson: Introduce component framework
 support

Hi,


On 2024/7/29 14:40, Markus Elfring wrote:
> …
>> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
>> @@ -0,0 +1,108 @@
> …
>> +#ifndef __LOONGSON_DRV_H__
>> +#define __LOONGSON_DRV_H__
> …
>
> I suggest to omit leading underscores from such identifiers.
> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier


I suggest add this rules to the checkpatch.pl script,

It's more safe to follow *after* your suggestion is accepted.

After all, the checkpatch.pl is de-facto standard.

checkpatch.pl is happy about my patch for now.


> Regards,
> Markus

-- 
Best regards,
Sui