[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Zqk39lppymxijGvP@x1>
Date: Tue, 30 Jul 2024 15:59:02 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: linux@...blig.org, kan.liang@...ux.intel.com,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf test pmu: Remove unused test_pmus
On Mon, Jul 29, 2024 at 07:52:53AM -0700, Ian Rogers wrote:
> On Sat, Jul 27, 2024 at 10:59 AM <linux@...blig.org> wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> >
> > Commit aa1551f299ba ("perf test pmu: Refactor format test and exposed
> > test APIs") added the 'test_pmus' list, but didn't use it.
> > (It seems to put them on the other_pmus list?)
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>
> Strange that the compiler doesn't warn about unused stuff like this,
> we get unused variables within a function and unused static
> functions...
>
> Reviewed-by: Ian Rogers <irogers@...gle.com>
Thanks, applied to tmp.perf-tools-next,
- Arnaldo
> Possibly:
> Fixes: aa1551f299ba ("perf test pmu: Refactor format test and exposed
> test APIs")
>
> Thanks,
> Ian
>
> > ---
> > tools/perf/tests/pmu.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/tests/pmu.c b/tools/perf/tests/pmu.c
> > index 40132655ccd1..0b2f04a55d7b 100644
> > --- a/tools/perf/tests/pmu.c
> > +++ b/tools/perf/tests/pmu.c
> > @@ -18,9 +18,6 @@
> > #include <sys/stat.h>
> > #include <sys/types.h>
> >
> > -/* Fake PMUs created in temp directory. */
> > -static LIST_HEAD(test_pmus);
> > -
> > /* Cleanup test PMU directory. */
> > static int test_pmu_put(const char *dir, struct perf_pmu *pmu)
> > {
> > --
> > 2.45.2
> >
Powered by blists - more mailing lists