linux-kernel - Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lJ87fvo0QzsVinjBdNVA7jnCEFm0-GBVJhFpFwKWCIS1M-kiuXP_mefSzm8G2Iplic1LlekmwUD6OODDJAtiDOPuDZ08HT965Tkmibgn6fE=@urja.dev>
Date: Tue, 30 Jul 2024 19:07:44 +0000
From: Urja <urja@...a.dev>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Lee Jones <lee@...nel.org>, Dmitrii Osipenko <dmitry.osipenko@...labora.com>, Mark Brown <broonie@...nel.org>, Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org, linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...labora.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

Hi,

On Tuesday, 30 July 2024 at 9:05 PM, Sebastian Reichel <sebastian.reichel@...labora.com> wrote:

> To avoid this we keep the SYS_OFF_MODE_POWER_OFF_PREPARE handler for the
> SPI backend. This is not great, but at least avoids regressions and the
> fix should be small enough to allow backporting.
> 
> As a side-effect this also works around a shutdown problem on the Asus
> C201. For reasons unknown that skips calling the prepare handler and
> directly calls the final shutdown handler.

I can clarify that bit a little - basically, when the handler is registered
as a poweroff prepare handler, the kernel thinks that the C201 cannot poweroff
and converts the poweroff into a halt, so I assume the
power_off_handler_list is empty - which makes sense, the C201 has no firmware
to call or other poweroff methods that I'd be aware of.
(See kernel/reboot.c line 746 and 683.) 

Anyways, this patch works on the C201 (tested on top of 6.11-rc1).
Tested-by: Urja <urja@...a.dev>

Thank you
--
Urja Rannikko