linux-kernel - Re: [PATCH] staging: rtl8723bs: rtw_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <800efa55-1765-48ea-8648-f9a6739342b6@gmail.com>
Date: Tue, 30 Jul 2024 21:18:53 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Santiago Ruano Rincón <santiagorr@...eup.net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: helen.koike@...labora.com, ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] staging: rtl8723bs: rtw_mlme_ext: replace spaces by tabs

On 7/30/24 10:05, Santiago Ruano Rincón wrote:
> Fix checkpatch error "ERROR: code indent should use tabs where possible"
> in include/rtw_mlme_ext.h:388.
> 
> Signed-off-by: Santiago Ruano Rincón <santiagorr@...eup.net>
> 
> ---
> I am (mostly) a newcommer. Could you please tell me if there is anything
> wrong with this patch? Thank you!
> 
> checkpatch reports a warning in line 387:
> "WARNING: line length of 135 exceeds 100 columns"
> Should I fix the warning in the same patch, or should I send a second
> patch to fix it?
> ---
> ---
>   drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> index 5b8574f5a..720aeeb00 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> @@ -384,8 +384,8 @@ struct mlme_ext_priv {
>   	unsigned char default_supported_mcs_set[16];
>   
>   	struct ss_res		sitesurvey_res;
> -	struct mlme_ext_info mlmext_info;/* for sta/adhoc mode, including current scanning/connecting/connected related info. */
> -                                                     /* for ap mode, network includes ap's cap_info */
> +	struct mlme_ext_info mlmext_info;	/* for sta/adhoc mode, including current scanning/connecting/connected related info. */
> +						/* for ap mode, network includes ap's cap_info */
>   	struct timer_list		survey_timer;
>   	struct timer_list		link_timer;
>   	struct timer_list		sa_query_timer;


Hi Santiago,

it could be two patches or one. You are only allowed to do one thing at 
a time. So it is also a little depending on your description. The way 
you describe this it is more like two patches.
If your description would be like:

Insert line break to comment, that exceeds 100 columns, to improve 
readability.

It would be OK to correct the indent as well.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

In case of questions feel free to contact me directly.

Thanks for your support.

Bye Philipp