linux-kernel - Re: [PATCH] drm/msm/dp: enable widebus on all relevant chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <872449ad-987a-4e15-bfb0-bf5572cf9302@quicinc.com>
Date: Tue, 30 Jul 2024 12:54:28 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <freedreno@...ts.freedesktop.org>, Rob Clark <robdclark@...il.com>,
        "Sean
 Paul" <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David Airlie" <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <quic_jesszhan@...cinc.com>,
        <swboyd@...omium.org>, <dianders@...omium.org>,
        <neil.armstrong@...aro.org>, <andersson@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dp: enable widebus on all relevant chipsets



On 7/13/2024 3:55 PM, Dmitry Baryshkov wrote:
> On Thu, Jul 11, 2024 at 03:48:50PM GMT, Abhinav Kumar wrote:
>> Hardware document indicates that widebus is recommended on DP on all
>> MDSS chipsets starting version 5.x.x and above.
>>
>> Follow the guideline and mark widebus support on all relevant
>> chipsets for DP.
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
>> ---
>>   drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
> 
> Although it doesn't seem to fix the 4k screen corruption, I think it's
> still a proper patch (and we should be following hardware
> documentation).
> 
> With the Fixes tags in place:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 

Thanks, I have added the Fixes tags and re-pushed.

I have added only sm8650's tag and another change which re-used sc7180's 
dp_descs without retaining the widebus_supported bit.

The reason I didnt add others is because widebus support itself was 
added only later to DP driver compared to the other ones.

If I am missing any Fixes tag, pls let me know and I can fix it while 
applying.