[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <18b83c34-c0e4-466c-aaa1-fff38c507e9a@lunn.ch>
Date: Tue, 30 Jul 2024 22:14:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Swathi K S <swathi.ks@...sung.com>
Cc: krzk@...nel.org, robh@...nel.org, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
conor+dt@...nel.org, richardcochran@...il.com,
mcoquelin.stm32@...il.com, alim.akhtar@...sung.com,
linux-fsd@...la.com, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, alexandre.torgue@...s.st.com,
peppe.cavallaro@...com, joabreu@...opsys.com, rcsekar@...sung.com,
ssiddha@...la.com, jayati.sahu@...sung.com,
pankaj.dubey@...sung.com, ravi.patel@...sung.com,
gost.dev@...sung.com
Subject: Re: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
> +static int dwc_eqos_rxmux_setup(void *priv, bool external)
> +{
> + int i = 0;
> + struct fsd_eqos_plat_data *plat = priv;
> + struct clk *rx1 = NULL;
> + struct clk *rx2 = NULL;
> + struct clk *rx3 = NULL;
Reverse Christmas tree please.
> @@ -264,6 +264,7 @@ struct plat_stmmacenet_data {
> void (*ptp_clk_freq_config)(struct stmmac_priv *priv);
> int (*init)(struct platform_device *pdev, void *priv);
> void (*exit)(struct platform_device *pdev, void *priv);
> + int (*rxmux_setup)(void *priv, bool external);
> struct mac_device_info *(*setup)(void *priv);
> int (*clks_config)(void *priv, bool enabled);
> int (*crosststamp)(ktime_t *device, struct system_counterval_t *system,
It would be good if one of the stmmas Maintainers looked at
this. There are already a lot of function pointers here, we should not
be added another one if one of the exiting ones could be used.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists