linux-kernel - Re: [PATCH 2/2] arm/arm64: dts: arm: Use generic clock and regulator nodenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKLjy=X9_7=UiEwN-uO3+yuofv_xQcmr-1d00w5LuaWWQ@mail.gmail.com>
Date: Tue, 30 Jul 2024 14:45:13 -0600
From: Rob Herring <robh@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Linus Walleij <linus.walleij@...aro.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Liviu Dudau <liviu.dudau@....com>, 
	Sudeep Holla <sudeep.holla@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm/arm64: dts: arm: Use generic clock and regulator nodenames

On Mon, Jul 29, 2024 at 2:31 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Tue, May 28, 2024 at 02:15:32PM -0500, Rob Herring (Arm) wrote:
> > With the recent defining of preferred naming for fixed clock and
> > regulator nodes, convert the Arm Ltd. boards to use the preferred
> > names. In the cases which had a unit-address, warnings about missing
> > "reg" property are fixed.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
>
> With this patch in the tree, all versatileab/pb qemu emulations
> fail silently (no console output). Reverting this patch fixes
> the problem. Bisect log is attached for reference.

The problem is fixed-factor-clock driver can't handle 2 clocks with
the same node name (at different paths), and then the serial driver
(and others) defer. Really, that should be fixed, but I'm going to do
the simple fix and rename one to 'clock-pclk' in line with other Arm
boards.

Rob