linux-kernel - Re: [PATCH v6 0/5] x86/pkeys: update PKRU to enable pkey 0 before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20B4F26C-A5E8-433C-A441-EAAEE8A31658@oracle.com>
Date: Tue, 30 Jul 2024 23:06:51 +0000
From: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
To: Jeff Xu <jeffxu@...omium.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>, Ingo
 Molnar <mingo@...nel.org>,
        Keith Lucas <keith.lucas@...cle.com>,
        "rick.p.edgecombe@...el.com" <rick.p.edgecombe@...el.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Jorge Lucangeli Obes
	<jorgelo@...omium.org>,
        Jeff Xu <jeffxu@...gle.com>, Kees Cook
	<keescook@...omium.org>,
        Stephen Röttger
	<sroettger@...gle.com>,
        Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH v6 0/5] x86/pkeys: update PKRU to enable pkey 0 before



> On Jul 16, 2024, at 9:25 PM, Jeff Xu <jeffxu@...omium.org> wrote:
> 
> Hi Aruna,
> 
> I added Rick who commented on the previous version of patch. I added
> Kees/Jorge/Stephan/Yann,  they expressed interest in similar
> functionality before. It would be best to keep them in future versions
> of this patch.
> 
> I also add linux-mm for more reviews/feedback on signal handling path.
> 
> On Thu, Jun 27, 2024 at 2:17 PM Aruna Ramakrishna
> <aruna.ramakrishna@...cle.com> wrote:
>> 
>> v6 updates:
>> - Rebased patchset to v6.10.0-rc5
>> - Changed sig_prepare_pkru() back to enabling all pkeys, based on
>> discussion with Jeff Xu
> Thanks for taking the suggestion.
> 
>> 
>> As Jeff mentioned, I'm unsure if we need to retain the changes to the
>> 32-bit functions. Maintainers - please advise.
>> 
> It is possible to  reduce the size of change.
> Not touching the ia32 or x32 code path also means less test in
> multiple architectures and less risk of regression.

Apologies for the delay in responding - I was on vacation and got back
yesterday.

I agree, I’m unsure if 32-bit support is needed here - as you pointed out in an
earlier email, the man page says:
“The feature is only available in 64-bit mode, even though there is theoretically
space in the PAE PTEs.”

I was hoping that Dave/Thomas would review and clarify. I will remove the
32-bit support from this patchset and send out a v7.

Thanks,
Aruna