linux-kernel - Re: [PATCH] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mvdR7QKTarCS8AabyEr0wiZ9AJgXD=toHkRDmLLnu=BA@mail.gmail.com>
Date: Wed, 31 Jul 2024 01:39:59 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Zehui Xu <zehuixu@....edu.cn>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, a.hindborg@...sung.com, aliceryhl@...gle.com, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

On Wed, Jul 31, 2024 at 12:21 AM Zehui Xu <zehuixu@....edu.cn> wrote:
>
> GCC recently added the -fmin-function-alignment option, which will appear in GCC 14. However, this flag can cause issues when passed to the Rust Makefile and affect the bindgen process. Bindgen relies on libclang to parse C code, and currently does not support the -fmin-function-alignment flag, leading to compilation failures when GCC 14 is used.
>
> This patch addresses the issue by adding -fmin-function-alignment to the bindgen_skip_c_flags in rust/Makefile, ensuring it is skipped during the bindgen process. This prevents the flag from causing compilation issues and maintains compatibility with the upcoming GCC 14.

Thanks for the patch!

> This is my first patch to the kernel, if there are any issues or improvements needed, please let me know. ;)

It looks OK, a couple nits are that you would normally not put this
line here (in the commit message), but below the `---` line (which
means it would not go into the repository).

In addition, normally you would: wrap your commit messages to a
reasonable length, use `scripts/checkpatch.pl` to check for this and
other issues, use the "Link" tag instead of "Reference:", avoid
leaving empty lines between tags and ideally use `git format-patch
--base` to specify the base of your patch (not really needed in many
cases, but it is always nice to have around).

If you can try that and send a v2, that would be nice.

But apart from those nits, it seems fine -- welcome!

Cheers,
Miguel