linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix spacing issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024073011-gory-knapsack-7235@gregkh>
Date: Tue, 30 Jul 2024 08:52:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Benjamin Somers <benjamin.somers@...el.fr>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht, helen.koike@...labora.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix spacing issues

On Tue, Jul 30, 2024 at 06:47:45AM +0000, Benjamin Somers wrote:
> This patch fixes spacing issues reported by checkpatch on lines 39-40
> 
> Signed-off-by: Benjamin Somers <benjamin.somers@...el.fr>
> 
> ---
> This is my first patch to the kernel
> ---
> ---
>  drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> index 188ed7e26..e470abfc2 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> @@ -36,8 +36,8 @@
>  	#include <linux/list.h>
>  	#include <linux/vmalloc.h>
>  
> -/* 	#include <linux/ieee80211.h> */
> -        #include <net/ieee80211_radiotap.h>
> +	/* #include <linux/ieee80211.h> */
> +	#include <net/ieee80211_radiotap.h>

Why not just remove the commented out line entirely?

And this is indented way too much, something went wrong :(

thanks,

greg k-h