linux-kernel - Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e72cc56a-3066-4cb8-848d-bfe27a48c095@suse.com>
Date: Tue, 30 Jul 2024 09:09:05 +0200
From: Oliver Neukum <oneukum@...e.com>
To: Abhishek Tamboli <abhishektamboli9@...il.com>, stern@...land.harvard.edu
Cc: gregkh@...uxfoundation.org, usb-storage@...ts.one-eyed-alien.net,
 linux-usb@...r.kernel.org, skhan@...uxfoundation.org,
 dan.carpenter@...aro.org, rbmarliere@...il.com,
 linux-kernel-mentees@...ts.linuxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings



On 29.07.24 20:23, Abhishek Tamboli wrote:
> Change bl_len from u16 to u32 to accommodate the necessary bit shifts.

Hi,

while this patch is technically correct, it papers over the issue.
Could you please

1. use a constant, where a constant is used
2. use the macros for converting endianness

	Regards
		Oliver